aadsm marked an inline comment as done. aadsm added inline comments.
================ Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:2091-2093 + DataExtractor auxv_data(buffer_or_error.get()->getBufferStart(), + buffer_or_error.get()->getBufferSize(), + GetByteOrder(), GetAddressByteSize()); ---------------- clayborg wrote: > We need to get a copy of the data here right? I believe the "buffer_or_error" > local variable will go out of scope and the data pointed to will be freed. > You can use: > ``` > lldb::offset_t DataExtractor::CopyData(lldb::offset_t offset, > lldb::offset_t length, void *dst) const; > ``` > which will copy of the data and internally own it in a DataBufferSP. Or you > can create a DataBufferSP yourself using DataBufferHeap and placing it into a > DataBufferSP and then passing that to the DataExtractor constructor or > SetData method. > Forgot to answer this, this is actually not needed because the ELFAuxVector copies what's given to it, it doesn't keep a a reference to the passed data. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62500/new/ https://reviews.llvm.org/D62500 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
