I've tried it out not and it works -- I think it's good to go then. The unit tests, was that a debug build by any chance? I think we are missing some dependency there which shows up only on debug builds, but I haven't dug into that yet.
On 7 March 2017 at 22:28, Zachary Turner <ztur...@google.com> wrote: > I can run build TargetTests though (I guess it doesn't depend on editline), > and that one passes. > > On Tue, Mar 7, 2017 at 2:26 PM Zachary Turner <ztur...@google.com> wrote: >> >> ============= >> Issue Details >> ============= >> UNEXPECTED SUCCESS: test_and_run_command_dwarf >> (lang/c/register_variables/TestRegisterVariables.py) >> UNEXPECTED SUCCESS: test_and_run_command_dwo >> (lang/c/register_variables/TestRegisterVariables.py) >> UNEXPECTED SUCCESS: test_dwarf >> (functionalities/thread/exit_during_break/TestExitDuringBreak.py) >> UNEXPECTED SUCCESS: test_dwo >> (functionalities/thread/exit_during_break/TestExitDuringBreak.py) >> UNEXPECTED SUCCESS: test_lldbmi_gdb_set_target_async_off >> (tools/lldb-mi/TestMiGdbSetShow.py) >> UNEXPECTED SUCCESS: test_lldbmi_process_output >> (tools/lldb-mi/syntax/TestMiSyntax.py) >> UNEXPECTED SUCCESS: test_lldbmi_settings_set_target_run_args_after >> (tools/lldb-mi/interpreter/TestMiInterpreterExec.py) >> UNEXPECTED SUCCESS: test_multiple_debuggers_dwarf >> (api/multiple-debuggers/TestMultipleDebuggers.py) >> UNEXPECTED SUCCESS: test_process_interrupt_dwo >> (functionalities/thread/state/TestThreadStates.py) >> UNEXPECTED SUCCESS: test_sb_api_listener_resume_dwarf >> (api/multithreaded/TestMultithreaded.py) >> UNEXPECTED SUCCESS: test_sb_api_listener_resume_dwo >> (api/multithreaded/TestMultithreaded.py) >> UNEXPECTED SUCCESS: test_with_dwarf (lang/cpp/printf/TestPrintf.py) >> UNEXPECTED SUCCESS: test_with_dwo (lang/cpp/printf/TestPrintf.py) >> >> =================== >> Test Result Summary >> =================== >> Test Methods: 1905 >> Reruns: 0 >> Success: 1203 >> Expected Failure: 117 >> Failure: 0 >> Error: 0 >> Exceptional Exit: 0 >> Unexpected Success: 13 >> Skip: 572 >> Timeout: 0 >> Expected Timeout: 0 >> >> I can't seem to run unittests because I'm getting undefined references to >> editline which I haven't dug into, but the regular tests pass. >> >> On Tue, Mar 7, 2017 at 1:47 PM Pavel Labath via Phabricator >> <revi...@reviews.llvm.org> wrote: >>> >>> labath accepted this revision. >>> labath added a comment. >>> This revision is now accepted and ready to land. >>> >>> OK, let's give this another shot. (I haven't tried it on linux yet, so if >>> you haven't either then let's wait until tomorrow, or maybe @eugene could >>> try it out (?)). I don't think we need to be worried about symlink overwrite >>> in the ModuleCache test. >>> >>> >>> >>> ================ >>> Comment at: llvm/include/llvm/Support/FileSystem.h:500 >>> +/// @param result Set to true if \a path is a directory (after following >>> +/// symlinks, false if it is not. Undefined otherwise. >>> /// @returns errc::success if result has been successfully set, >>> otherwise a >>> ---------------- >>> missing closing paren here >>> >>> >>> https://reviews.llvm.org/D30698 >>> >>> >>> > _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
