labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

OK, let's give this another shot. (I haven't tried it on linux yet, so if you 
haven't either then let's wait until tomorrow, or maybe @eugene could try it 
out (?)). I don't think we need to be worried about symlink overwrite in the 
ModuleCache test.



================
Comment at: llvm/include/llvm/Support/FileSystem.h:500
+/// @param result Set to true if \a path is a directory (after following
+///               symlinks, false if it is not. Undefined otherwise.
 /// @returns errc::success if result has been successfully set, otherwise a
----------------
missing closing paren here


https://reviews.llvm.org/D30698



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to