zturner added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:197 + namespace fs = llvm::sys::fs; + if (fs::get_file_type(local_path_spec.GetPath(), false) != + fs::file_type::symlink_file) ---------------- labath wrote: > labath wrote: > > This still breaks TestCompDirSymLink.py. I haven't yet dug into why, but it > > looks like some problem in the get_file_type implementation. > ok, so the problem is in `llvm::sys::fs::fillStatus` implementation. It is > missing the call to `S_ISLNK` to decode the symlink bit (probably because it > was not necessary until now). I literally just came to the same conclusion. Glad we agree on the fix! I'll also do a full audit of all the changes in regards to your other comment about the functionality change, and make sure that same mistake does not appear anywhere else. https://reviews.llvm.org/D30698 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
