labath added a comment.

Unfortunately, this does not seem to help. I'll try to debug today if I can 
find the time.



================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:197
+  namespace fs = llvm::sys::fs;
+  if (fs::get_file_type(local_path_spec.GetPath(), false) !=
+      fs::file_type::symlink_file)
----------------
This still breaks TestCompDirSymLink.py. I haven't yet dug into why, but it 
looks like some problem in the get_file_type implementation.


================
Comment at: lldb/source/Target/ModuleCache.cpp:70
+  llvm::sys::fs::file_status st;
+  if (status(dir_path.GetPath(), st, false))
+    return Error("Could not stat path");
----------------
This changes behavior (and breaks ModuleCache unit tests). The point of this 
was to check whether path is a directory, so if we cannot stat it, we should 
still try to create it.


https://reviews.llvm.org/D30698



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to