================ @@ -34,6 +34,23 @@ function convertToInteger(value: any): number | undefined { export class LLDBDapConfigurationProvider implements vscode.DebugConfigurationProvider { + resolveDebugConfiguration( + _folder: vscode.WorkspaceFolder | undefined, + debugConfiguration: vscode.DebugConfiguration, + _token?: vscode.CancellationToken, + ): vscode.ProviderResult<vscode.DebugConfiguration> { + // Default "pid" to ${command:pickProcess} if neither "pid" nor "program" are specified + // in an "attach" request. + if ( + debugConfiguration.request === "attach" && + !("pid" in debugConfiguration) && + !("program" in debugConfiguration) + ) { + debugConfiguration.pid = "${command:pickProcess}"; ---------------- matthewbastien wrote:
I've updated both of these to better reflect my changes. I did a pretty major overhaul of the `README` section on attaching and would appreciate another thorough review there to make sure the wording sounds good. https://github.com/llvm/llvm-project/pull/128943 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits