================
@@ -34,6 +34,23 @@ function convertToInteger(value: any): number | undefined {
export class LLDBDapConfigurationProvider
implements vscode.DebugConfigurationProvider
{
+ resolveDebugConfiguration(
+ _folder: vscode.WorkspaceFolder | undefined,
+ debugConfiguration: vscode.DebugConfiguration,
+ _token?: vscode.CancellationToken,
+ ): vscode.ProviderResult<vscode.DebugConfiguration> {
+ // Default "pid" to ${command:pickProcess} if neither "pid" nor "program"
are specified
+ // in an "attach" request.
+ if (
+ debugConfiguration.request === "attach" &&
+ !("pid" in debugConfiguration) &&
----------------
matthewbastien wrote:
Makes sense to me, though the process picker does conflict with the `waitFor`
property, if set. I'm going to add a check for that instead.
Quick question with regards to attach configurations, though: shouldn't the
`program` be required for LLDB to properly load debug symbols? Or more simply:
would it make any sense to debug a process without a `program` specified? I
know the C/C++ extension does require the `program` property to be set. Seems
like we should be doing the same.
https://github.com/llvm/llvm-project/pull/128943
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
