================ @@ -34,6 +34,23 @@ function convertToInteger(value: any): number | undefined { export class LLDBDapConfigurationProvider implements vscode.DebugConfigurationProvider { + resolveDebugConfiguration( + _folder: vscode.WorkspaceFolder | undefined, + debugConfiguration: vscode.DebugConfiguration, + _token?: vscode.CancellationToken, + ): vscode.ProviderResult<vscode.DebugConfiguration> { + // Default "pid" to ${command:pickProcess} if neither "pid" nor "program" are specified + // in an "attach" request. + if ( + debugConfiguration.request === "attach" && + !("pid" in debugConfiguration) && ---------------- matthewbastien wrote:
Sounds like we can leave it optional then. I've updated the PR to always use the process picker except when `waitFor` is set to `true` as that appears to be handled by `lldb-dap` rather than the extension. https://github.com/llvm/llvm-project/pull/128943 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits