On Thu, Apr 17, 2008 at 11:19:39PM -0500, Kumar Gala wrote: [...] >>> + * interval value, and fires the interrupt when the value is >>> reached. This >>> + * function will reduce the precision of the timer as needed in >>> order for the >>> + * requested timeout to fit in a 16-bit register. >>> + */ >>> +int gtm_reset_timer16(struct gtm_timer *tmr, unsigned long usec, >>> bool reload) >>> +{ >>> + /* quite obvious, frequency which is enough for µSec precision */ >>> + int freq = 1000000; >>> + unsigned int bit; >>> + >>> + bit = fls_long(usec); >>> + if (bit > 15) { >>> + freq >>= bit - 15; >>> + usec >>= bit - 15; >>> + } >> >> if (!freq) >> return -EINVAL; > > do you want me to fix this up on commit or are you going to respin the > patch set based on feedback?
I would better respin the whole thing. Will do this today. Thanks, -- Anton Vorontsov email: [EMAIL PROTECTED] irc://irc.freenode.net/bd2 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev