On Sat, Mar 22, 2008 at 4:49 AM, Anatolij Gustschin <[EMAIL PROTECTED]> wrote:
> Checking bcom_eng pointer for NULL before referencing data pointed
> by it prevents oopsing, but fec driver still doesn't work (because
> of the lost bestcomm match and resulted task allocation failure).
> Actually the compatible property exists and should match and so
> the fec driver shoud work.
>
> I suggest removing .type = "dma-controller" from the bestcomm driver's
> mpc52xx_bcom_of_match table to solve the problem.
>
> What do you think?
Yes, I agree. .compatible is completely sufficient to match the
device so .type is superfluous in this case. Removing it is
appropriate.
I've already sent a patch to fix the null pointer deref.
Acked-by: Grant Likely <[EMAIL PROTECTED]>
Paul, here's one more bug fix to pick up for .25. (I think we're done now)
Cheers,
g.
>
> Signed-off-by: Anatolij Gustschin <[EMAIL PROTECTED]>
> ---
> diff --git a/arch/powerpc/sysdev/bestcomm/bestcomm.c
> b/arch/powerpc/sysdev/bestcomm/bestcomm.c
> index f589999..137d830 100644
> --- a/arch/powerpc/sysdev/bestcomm/bestcomm.c
> +++ b/arch/powerpc/sysdev/bestcomm/bestcomm.c
> @@ -484,8 +484,8 @@ mpc52xx_bcom_remove(struct of_device *op)
> }
>
> static struct of_device_id mpc52xx_bcom_of_match[] = {
> - { .type = "dma-controller", .compatible = "fsl,mpc5200-bestcomm", },
> - { .type = "dma-controller", .compatible = "mpc5200-bestcomm", },
> + { .compatible = "fsl,mpc5200-bestcomm", },
> + { .compatible = "mpc5200-bestcomm", },
> {},
> };
>
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
