On Thu, Mar 20, 2008 at 10:17 AM, Bartlomiej Sieka <[EMAIL PROTECTED]> wrote:
> Anatolij Gustschin wrote:
> > Hello Wolfgang,
> >
> > Wolfgang Grandegger wrote:
> >
> >> I just tried Linux 2.6.25-rc6 on my TQM5200 module and got the attached
> >> oops. Are there any known patches fixing the problems?
> >
> > try the patch below for tqm5200.dts, rebuild dtb and boot
> > again. Not sure if it works for Linux 2.6.25-rc6, but for
> > 2.6.25-rc3 it does.
>
> It helps 2.6.25-rc6 too - thanks Anatolij.
>
>
> >
> > Anatolij
> > --
> > diff --git a/arch/powerpc/boot/dts/tqm5200.dts
> > b/arch/powerpc/boot/dts/tqm5200.dts
> > index c86464f..7c23bb3 100644
> > --- a/arch/powerpc/boot/dts/tqm5200.dts
> > +++ b/arch/powerpc/boot/dts/tqm5200.dts
> > @@ -83,6 +83,7 @@
> > };
> >
> > [EMAIL PROTECTED] {
> > + device_type = "dma-controller";
>
> This actually fixes the Oops.
Hmm, this sounds like a band-aid; the kernel shouldn't oops if this is
missing from the device tree. Fail, perhaps, but oops is worrisome.
Would someone like to investigate?
In fact, device_type should not be necessary at all, but that's beside
the point.
> > @@ -127,10 +128,25 @@
> > [EMAIL PROTECTED] {
> > device_type = "network";
> > compatible = "fsl,mpc5200-fec";
> > - reg = <3000 800>;
> > + reg = <3000 400>;
> > local-mac-address = [ 00 00 00 00 00 00 ];
> > interrupts = <2 5 0>;
> > interrupt-parent = <&mpc5200_pic>;
> > + phy-handle = <&phy0>;
> > + };
> > +
> > + [EMAIL PROTECTED] {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + compatible = "fsl,mpc5200b-mdio";
> > + reg = <3000 400>; // fec range, since we need to
> > setup fec interrupts
> > + interrupts = <2 5 0>; // these are for "mii command
> > finished", not link changes & co.
> > + interrupt-parent = <&mpc5200_pic>;
> > +
> > + phy0:[EMAIL PROTECTED] {
> > + device_type = "ethernet-phy";
> > + reg = <0>;
> > + };
>
> And this fixes networking issues (NFS-mounted rootfs timeouts, etc).
> BTW: it's been posted a while back
> (http://patchwork.ozlabs.org/linuxppc/patch?q=Balakowicz&id=16197) but
> didn't get merged.
>
> Grant -- any chances these fixes could be rushed upstream?
Nuts, I dropped it on the floor. I'll pick this up.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
