----- Original Message -----
From: "David Kastrup" <d...@gnu.org>
To: "Phil Holmes" <m...@philholmes.net>
Cc: <tdanielsmu...@googlemail.com>; <philehol...@googlemail.com>;
<re...@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org>
Sent: Thursday, August 21, 2014 2:43 PM
Subject: Re: Adds incipit section to NR (issue 108270043
byphilehol...@googlemail.com)
"Phil Holmes" <m...@philholmes.net> writes:
----- Original Message -----
From: "David Kastrup" <d...@gnu.org>
To: "Phil Holmes" <em...@philholmes.net>
Cc: <re...@codereview-hr.appspotmail.com>;
<philehol...@googlemail.com>; <tdanielsmu...@googlemail.com>;
<lilypond-devel@gnu.org>
Sent: Thursday, August 21, 2014 1:26 PM
Subject: Re: Adds incipit section to NR (issue 108270043
byphilehol...@googlemail.com)
At any rate: why do you believe that an instrument should be formatted
differently before an incipit than before a regular score?
I explained this in some detail in my email timed 11:20-ish BST. It's
because of the way \indent is used both for the incipit width and the
indent.
It isn't really.
After using that "reference" for digging up the relevant quote, taking
only about a quarter of an hour, I arrive at
I'll pick up on the right/left alignment issue first. I believe I
concluded right-aligned to be the correct answer because we are
effectively reusing the \indent value to set the width of the
incipit, including instrument name. Now, if someone wishes to have
the first line actually indented, this makes it impossible. See the
3rd image attached as an example.
See? The instrument name ("Altus") is stuck to the left margin and
it's impossible to adjust its position. Right align it, however,
and the first line can be indented to the value desired (with a
little experimentation). The fourth image shows this. This is
surely far better?
At the current state of the debate I have a hard time viewing this as
anything but a straw man. The default, as I have written several times
already, is _not_ left alignment. It is #CENTER. Indeed, if you set
the instrument name alignment to the NON-standard #LEFT, the instrument
name, as long as \indent (or, in the case of the incipit,
\indent-\incipit-width) provides enough space, will not budge from the
left edge. No question about that. But that's not the issue at all.
That was my mistake, for which I apologise. I don't believe you'd pointed
this out prior to my earlier mail.
Unless incipit-width is too small to accommodate the incipit in the
first place, the amount of space available for the instrument name is
\indent-\incipit-width. Even in that case, I don't see that the natural
or best placement of the instrument name in the remaining space would be
at the right of the remaining space.
--
David Kastrup
And this is the nub of the discussion. There's nothing actually _wrong_
with my patch: it's just you don't like how it looks. I very much do. This
time I've attached a centre-aligned and a right-aligned example, and much
prefer the latter. And if you say right-aligned is wrong, you should also
write to Elaine Gould to correct her.
This takes me back to my previous mail. I'm very happy to attempt to
correct incorrect code, etc. However, I don't think it's good to have this
continuing debate simply about what looks better. You have one opinion, I
have another, and it's my patch.
--
Phil Holmes
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
