sc/source/filter/excel/excform.cxx | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
New commits:
commit bb70ecfdfd2117985627cc1b5e0de4b787969e7f
Author: Bogdan Buzea <buzea.bog...@libreoffice.org>
AuthorDate: Sun Oct 20 08:02:42 2024 +0200
Commit: David Gilbert <freedesk...@treblig.org>
CommitDate: Tue Nov 12 01:57:56 2024 +0100
tdf#163486: PVS: Identical branches
V1037 Two or more case-branches perform the same actions. Check lines: 921,
924
V1037 Two or more case-branches perform the same actions. Check lines:
1003, 1160
Change-Id: I42e78f2960b97a67625bfdb524b7f615833332ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175230
Reviewed-by: David Gilbert <freedesk...@treblig.org>
Tested-by: Jenkins
diff --git a/sc/source/filter/excel/excform.cxx
b/sc/source/filter/excel/excform.cxx
index ee7b4a65e542..e9e59b5fe6da 100644
--- a/sc/source/filter/excel/excform.cxx
+++ b/sc/source/filter/excel/excform.cxx
@@ -918,8 +918,6 @@ ConvErr ExcelToSc::Convert( ScRangeListTabs& rRangeList,
XclImpStream& aIn, std:
{ // SDK4 SDK5
case 0x01: // Array Formula [325 ]
// Array Formula or Shared Formula [ 277]
- nIgnore = (meBiff == EXC_BIFF2) ? 3 : 4;
- break;
case 0x02: // Data Table [325 277]
nIgnore = (meBiff == EXC_BIFF2) ? 3 : 4;
break;
@@ -1000,6 +998,9 @@ ConvErr ExcelToSc::Convert( ScRangeListTabs& rRangeList,
XclImpStream& aIn, std:
nIgnore = 1;
break;
case 0x1E: // Integer [315 266]
+ case 0x58:
+ case 0x78:
+ case 0x38: // Command-Equivalent Function [333 ]
nIgnore = 2;
break;
case 0x1F: // Number [315 266]
@@ -1154,11 +1155,6 @@ ConvErr ExcelToSc::Convert( ScRangeListTabs& rRangeList,
XclImpStream& aIn, std:
case 0x2F: // Incomplete Reference Subexpression... [332 282]
nIgnore = (meBiff == EXC_BIFF2) ? 1 : 2;
break;
- case 0x58:
- case 0x78:
- case 0x38: // Command-Equivalent Function [333 ]
- nIgnore = 2;
- break;
case 0x59:
case 0x79:
case 0x39: // Name or External Name [ 275]
