core.git: sc/source

[Xisco Fauli (via logerrit)]

 sc/source/ui/view/cellsh1.cxx |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 1e2b4e9765503f0beb30cc5298c36ededc0063c1
Author:     Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Thu Oct 31 16:24:41 2024 +0100
Commit:     Mike Kaganski <mike.kagan...@collabora.com>
CommitDate: Sun Nov 3 15:05:48 2024 +0100

    tdf#163486: PVS: parameter is always rewritten
    
    Since
    commit a9a665ed7a3198f4c0f6e521520491353ccfb182
    Author: Szymon Kłos <szymon.k...@collabora.com>
    Date:   Tue Jan 5 14:54:52 2021 +0100
    
        pivot table: make partial sum message box async
    
    V763    Parameter 'pSrcErrorId' is always rewritten in function body before 
being used.
    
    Change-Id: I51c2d1b0d01563d66e828d3ebfaf61f620992443
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175876
    Reviewed-by: Mike Kaganski <mike.kagan...@collabora.com>
    Tested-by: Jenkins

diff --git a/sc/source/ui/view/cellsh1.cxx b/sc/source/ui/view/cellsh1.cxx
index c12077c76d2e..498694644922 100644
--- a/sc/source/ui/view/cellsh1.cxx
+++ b/sc/source/ui/view/cellsh1.cxx
@@ -3374,13 +3374,13 @@ void RunPivotLayoutDialog(ScModule* pScMod,
 void SetupRangeForPivotTableDialog(const ScRange& rRange,
                                    ScAddress& rDestPos,
                                    ScDocument* pDoc,
-                                   TranslateId pSrcErrorId,
+                                   TranslateId& rSrcErrorId,
                                    std::unique_ptr<ScDPObject>& pNewDPObject)
 {
     ScSheetSourceDesc aShtDesc(pDoc);
     aShtDesc.SetSourceRange(rRange);
-    pSrcErrorId = aShtDesc.CheckSourceRange();
-    if (!pSrcErrorId)
+    rSrcErrorId = aShtDesc.CheckSourceRange();
+    if (!rSrcErrorId)
     {
         pNewDPObject.reset(new ScDPObject(pDoc));
         pNewDPObject->SetSheetDesc( aShtDesc );