sc/source/ui/view/formatsh.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 459a45800c5ae1502f0f8829fa96401243e6686a
Author: Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Mon Nov 11 14:36:56 2024 +0100
Commit: Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Mon Nov 11 23:19:39 2024 +0100
tdf#163486: PVS: call GetItemSet() once
V656 Variables 'aOldSet', 'aNewSet' are initialized through the call to
the same function. It's probably an error or un-optimized code. Consider
inspecting the 'pOldAttrs->GetItemSet()' expression. Check lines: 1181, 1182.
Change-Id: I44b7be1bfb53872109b39323f909d5e1fcc1a809
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176405
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>
diff --git a/sc/source/ui/view/formatsh.cxx b/sc/source/ui/view/formatsh.cxx
index 75e99b2033e4..14040f8c7168 100644
--- a/sc/source/ui/view/formatsh.cxx
+++ b/sc/source/ui/view/formatsh.cxx
@@ -1179,7 +1179,7 @@ void ScFormatShell::ExecuteAttr( SfxRequest& rReq )
{
const ScPatternAttr* pOldAttrs =
pTabViewShell->GetSelectionPattern();
SfxItemSet aOldSet(pOldAttrs->GetItemSet());
- SfxItemSet aNewSet(pOldAttrs->GetItemSet());
+ SfxItemSet aNewSet(aOldSet);
if(SID_ATTR_BORDER_DIAG_TLBR == nSlot)
{
