core.git: sc/source

[Bogdan Buzea (via logerrit)]

 sc/source/filter/excel/xeescher.cxx |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit 9a917ff65690b00cebb53f0c67bd91622a33351f
Author:     Bogdan Buzea <buzea.bog...@libreoffice.org>
AuthorDate: Mon Oct 21 11:34:03 2024 +0200
Commit:     David Gilbert <freedesk...@treblig.org>
CommitDate: Mon Nov 4 22:49:22 2024 +0100

    tdf#163486: PVS: Identical branches
    
    V1037 Two or more case-branches perform the same actions. Check lines: 778, 
793
    
    Change-Id: I2437bbac1bc952720d4ea3c43107c9d5e1ef1655
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175308
    Tested-by: Jenkins
    Reviewed-by: David Gilbert <freedesk...@treblig.org>

diff --git a/sc/source/filter/excel/xeescher.cxx 
b/sc/source/filter/excel/xeescher.cxx
index 7b23e9755162..61d0fc185433 100644
--- a/sc/source/filter/excel/xeescher.cxx
+++ b/sc/source/filter/excel/xeescher.cxx
@@ -775,6 +775,8 @@ XclExpTbxControlObj::XclExpTbxControlObj( 
XclExpObjectManager& rRoot, Reference<
         break;
         // Push button cannot be set to flat in Excel
         case FormCompType::COMMANDBUTTON:
+        // Group box does not support flat style (#i34712#)
+        case FormCompType::GROUPBOX:
             nApiBorder = AwtVisualEffect::LOOK3D;
         break;
         // Label does not support a border in Excel
@@ -788,10 +790,6 @@ XclExpTbxControlObj::XclExpTbxControlObj( 
XclExpObjectManager& rRoot, Reference<
             nApiButton = AwtVisualEffect::LOOK3D;
             nApiBorder = AwtVisualEffect::NONE;
         break;
-        // Group box does not support flat style (#i34712#)
-        case FormCompType::GROUPBOX:
-            nApiBorder = AwtVisualEffect::LOOK3D;
-        break;
     }
     mbFlatButton = nApiButton != AwtVisualEffect::LOOK3D;
     mbFlatBorder = nApiBorder != AwtVisualEffect::LOOK3D;