sc/source/filter/excel/excform8.cxx | 28 ++++++++++++----------------
1 file changed, 12 insertions(+), 16 deletions(-)
New commits:
commit 3c32c9323968bd26e5b4524ed4045bc2829207ee
Author: Bogdan Buzea <buzea.bog...@libreoffice.org>
AuthorDate: Sat Oct 19 17:41:45 2024 +0200
Commit: David Gilbert <freedesk...@treblig.org>
CommitDate: Wed Nov 6 18:16:19 2024 +0100
tdf#163486: PVS: Identical branches
V1037 Two or more case-branches perform the same actions. Check lines:
1114, 1129, 1261
Change-Id: I661f54f3aaa84002e3013439ea762afa4a251857
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175210
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesk...@treblig.org>
diff --git a/sc/source/filter/excel/excform8.cxx
b/sc/source/filter/excel/excform8.cxx
index 0ab1ca02ab25..1984d2c362da 100644
--- a/sc/source/filter/excel/excform8.cxx
+++ b/sc/source/filter/excel/excform8.cxx
@@ -1092,17 +1092,6 @@ ConvErr ExcelToSc8::Convert( ScRangeListTabs&
rRangeList, XclImpStream& aIn, std
rRangeList.Append(aCRD.toAbs(GetDocImport().getDoc(),
aEingPos), nTab);
}
break;
- case 0x46:
- case 0x66:
- case 0x26: // Constant Reference Subexpression [321 271]
- case 0x47:
- case 0x67:
- case 0x27: // Erroneous Constant Reference Subexpr. [322 272]
- case 0x48:
- case 0x68:
- case 0x28: // Incomplete Constant Reference Subexpr.[331 281]
- aIn.Ignore( 6 ); // There isn't any more
- break;
case 0x49:
case 0x69:
case 0x29: // Variable Reference Subexpression [331 281]
@@ -1113,11 +1102,6 @@ ConvErr ExcelToSc8::Convert( ScRangeListTabs&
rRangeList, XclImpStream& aIn, std
case 0x2A: // Deleted Cell Reference [323 273]
aIn.Ignore( 3 );
break;
- case 0x4B:
- case 0x6B:
- case 0x2B: // Deleted Area Reference [323 273]
- aIn.Ignore( 6 );
- break;
case 0x4C:
case 0x6C:
case 0x2C: // Cell Reference Within a Name [323 ]
@@ -1245,6 +1229,18 @@ ConvErr ExcelToSc8::Convert( ScRangeListTabs&
rRangeList, XclImpStream& aIn, std
}
}
break;
+ case 0x46:
+ case 0x66:
+ case 0x26: // Constant Reference Subexpression [321 271]
+ case 0x47:
+ case 0x67:
+ case 0x27: // Erroneous Constant Reference Subexpr. [322 272]
+ case 0x48:
+ case 0x68:
+ case 0x28: // Incomplete Constant Reference Subexpr.[331 281]
+ case 0x4B:
+ case 0x6B:
+ case 0x2B: // Deleted Area Reference [323 273]
case 0x5C:
case 0x7C:
case 0x3C: // Deleted 3-D Cell Reference [ 277]
