Ken Moffat wrote: > Using the CFLAGS can be instructive (as in adding to the user's > CFLAGS instead of totally overriding them, as a few packages still > do). It also appears to be obviously correct, and therefore > minimises future maintenance if the code in systemd is moved. > > If you want to fork systemd, you could happily change the type (and > test it), but while you are working on the "add a Makefile to remove > the worst of upstream's changes" approach, I think that the sed is > likely to cause you more work in the future, not less. > > That's always the problem with seds for compilation problems - they > need to be checked against each new version to see if they still do > anything, as well as testing to see if it still compiles.
For every package I update, I check the new release when we have a sed or patch now. Sometimes the change comes from upstream, but not always. Changing the option changes every instance of off_t in all the code. In this case it's not a big deal. I only count 19 instances in the whole package, so it doesn't make any difference. I'll drop the sed in favor of the option change. -- Bruce -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
