-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5226/
-----------------------------------------------------------
Review request for Kopete.
Summary
-------
This patch fix systray icons missing reported by bug 222689. I am not
comfortable about this patch, I would like to receive better alternatives than
using the paths to the icons in $KDEDIR/share/apps/kopete/icons/oxygen, so I am
posting the patch here for suggestions. The add adds the account's picture to
the tooltip, if the icon is not available it adds the protocol icon instead.
The original problem is that the file handle 'kopete-account-icon:x:y' in img
src=\"kopete-account-icon:%3:%4\"> does not work with KStatusNotifierItem, that
is a problem for other KDE programs too. Maybe it is better fix
KStatusNotifierItem instead, maybe add a 'icon:/' file handle to it, so that
every KDE program could use icons in system tray tooltip.
This addresses bug 222689.
https://bugs.kde.org/show_bug.cgi?id=222689
Diffs
-----
/trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp 1170480
Diff: http://reviewboard.kde.org/r/5226/diff
Testing
-------
Screenshots
-----------
With patch applied
http://reviewboard.kde.org/r/5226/s/492/
Thanks,
Lamarque
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
