> On 2010-09-04 14:07:31, Igor Poboiko wrote:
> > It is strange that KIconLoader doesn't work for you. I think you should use
> > it instead of hardcoing icon path. As for me, it works fine. For example (I
> > used PyKDE4 here, but I don't think there will be problems with C++):
> >
> > In [1]: from PyKDE4.kdeui import KIconLoader
> >
> > In [2]: x = KIconLoader("kopete")
> > <unknown program name>(16727)/ KSharedDataCache::Private::mapSharedMemory:
> > Opening cache "/var/tmp/kdecache-eol/icon-cache.kcache" page size is 4096
> > <unknown program name>(16727)/ KSharedDataCache::Private::mapSharedMemory:
> > Attached to cache, determining if it must be initialized
> > <unknown program name>(16727)/ KSharedDataCache::Private::mapSharedMemory:
> > Cache fully initialized -- attached to memory mapping
> > <unknown program name>(16727)/ KSharedDataCache::Private::mapSharedMemory:
> > 4014080 bytes available out of 10485760
> >
> > In [3]: x.iconPath("icq_protocol", KIconLoader.Panel)
> > Out[3]:
> > PyQt4.QtCore.QString(u'/usr/share/apps/kopete/icons/oxygen/32x32/apps/icq_protocol.png')
>
> Igor Poboiko wrote:
> And you can use a->protocol()->pluginIcon() instead of comparing
> pluginId()
Also I think you should use account's custom icon
(Kopete::Account::customIcon()) if it is available (something like
a->customIcon().isEmpty() ? a->protocol()->pluginIcon() : a->customIcon()).
And I think it isn't good idea to show account's avatar there just because it
is resized to very small size (16x16 px) and looks ugly. But it is just my
opinion.
- Igor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5226/#review7403
-----------------------------------------------------------
On 2010-09-04 18:22:47, Lamarque Souza wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5226/
> -----------------------------------------------------------
>
> (Updated 2010-09-04 18:22:47)
>
>
> Review request for Kopete.
>
>
> Summary
> -------
>
> This patch fix systray icons missing reported by bug 222689. The add adds the
> account's picture to the tooltip, if the icon is not available it adds the
> protocol icon instead.
>
> The original problem is that the file handle 'kopete-account-icon:x:y' in img
> src=\"kopete-account-icon:%3:%4\"> does not work with KStatusNotifierItem,
> that is a problem for other KDE programs too. Maybe it is better fix
> KStatusNotifierItem instead, maybe add a 'icon:/' file handle to it, so that
> every KDE program could use icons in system tray tooltip.
>
>
> This addresses bug 222689.
> https://bugs.kde.org/show_bug.cgi?id=222689
>
>
> Diffs
> -----
>
> /trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.h 1082473
> /trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp 1170480
>
> Diff: http://svn.reviewboard.kde.org/r/5226/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> With patch applied
> http://svn.reviewboard.kde.org/r/5226/s/492/
>
>
> Thanks,
>
> Lamarque
>
>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
