-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5226/
-----------------------------------------------------------

(Updated 2010-09-04 22:11:22.147119)


Review request for Kopete.


Changes
-------

Ok, changed to show custom account icons or the protocol icon when the custom 
account icon is not available.


Summary
-------

This patch fix systray icons missing reported by bug 222689. The add adds the 
account's picture to the tooltip, if the icon is not available it adds the 
protocol icon instead.

The original problem is that the file handle 'kopete-account-icon:x:y' in img 
src=\"kopete-account-icon:%3:%4\"> does not work with KStatusNotifierItem, that 
is a problem for other KDE programs too. Maybe it is better fix 
KStatusNotifierItem instead, maybe add a 'icon:/' file handle to it, so that 
every KDE program could use icons in system tray tooltip.


This addresses bug 222689.
    https://bugs.kde.org/show_bug.cgi?id=222689


Diffs (updated)
-----

  /trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.h 1082473 
  /trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp 1170480 

Diff: http://svn.reviewboard.kde.org/r/5226/diff


Testing
-------


Screenshots
-----------

Old version
  http://svn.reviewboard.kde.org/r/5226/s/492/
New version
  http://svn.reviewboard.kde.org/r/5226/s/494/


Thanks,

Lamarque

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to