-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5226/#review7403
-----------------------------------------------------------
It is strange that KIconLoader doesn't work for you. I think you should use it
instead of hardcoing icon path. As for me, it works fine. For example (I used
PyKDE4 here, but I don't think there will be problems with C++):
In [1]: from PyKDE4.kdeui import KIconLoader
In [2]: x = KIconLoader("kopete")
<unknown program name>(16727)/ KSharedDataCache::Private::mapSharedMemory:
Opening cache "/var/tmp/kdecache-eol/icon-cache.kcache" page size is 4096
<unknown program name>(16727)/ KSharedDataCache::Private::mapSharedMemory:
Attached to cache, determining if it must be initialized
<unknown program name>(16727)/ KSharedDataCache::Private::mapSharedMemory:
Cache fully initialized -- attached to memory mapping
<unknown program name>(16727)/ KSharedDataCache::Private::mapSharedMemory:
4014080 bytes available out of 10485760
In [3]: x.iconPath("icq_protocol", KIconLoader.Panel)
Out[3]:
PyQt4.QtCore.QString(u'/usr/share/apps/kopete/icons/oxygen/32x32/apps/icq_protocol.png')
- Igor
On 2010-09-02 13:58:06, Lamarque Souza wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5226/
> -----------------------------------------------------------
>
> (Updated 2010-09-02 13:58:06)
>
>
> Review request for Kopete.
>
>
> Summary
> -------
>
> This patch fix systray icons missing reported by bug 222689. I am not
> comfortable about this patch, I would like to receive better alternatives
> than using the paths to the icons in $KDEDIR/share/apps/kopete/icons/oxygen,
> so I am posting the patch here for suggestions. The add adds the account's
> picture to the tooltip, if the icon is not available it adds the protocol
> icon instead.
>
> The original problem is that the file handle 'kopete-account-icon:x:y' in img
> src=\"kopete-account-icon:%3:%4\"> does not work with KStatusNotifierItem,
> that is a problem for other KDE programs too. Maybe it is better fix
> KStatusNotifierItem instead, maybe add a 'icon:/' file handle to it, so that
> every KDE program could use icons in system tray tooltip.
>
>
> This addresses bug 222689.
> https://bugs.kde.org/show_bug.cgi?id=222689
>
>
> Diffs
> -----
>
> /trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp 1170480
>
> Diff: http://svn.reviewboard.kde.org/r/5226/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> With patch applied
> http://svn.reviewboard.kde.org/r/5226/s/492/
>
>
> Thanks,
>
> Lamarque
>
>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
