mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> batchrenamedialog.cpp:40
> +#include <KJobWidgets/KJobWidgets>
> +#include <QtWidgets/QMenu>
> +#include <QtGui/QActionEvent>
remove QtWidget
> batchrenamedialog.cpp:41
> +#include <QtWidgets/QMenu>
> +#include <QtGui/QActionEvent>
> +
remove QtGui prefix
> batchrenamedialog.cpp:46
> +
> +BatchRenameDialog::BatchRenameDialog(QWidget *parent, const KFileItemList
> &items) : QDialog(parent)
> +{
new line before ": QDialog"
> batchrenamedialog.h:69
> +
> + KMessageWidget *m_messageWidget;
> + QTimer *m_timer;
it's a good idea to initialize to nullptr each pointer here.
So we can see problem easily.
> batchrenamedialogmodel_p.cpp:88
> +
> +BatchRenameDialogModel::BatchRenameDialogModel(QObject *parent, const
> KFileItemList &items) : QAbstractTableModel(parent)
> +{
new line before : QAbstr...
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14631
To: emateli, #frameworks, dfaure, mlaurent
Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel,
michaelh, bruns
