emateli updated this revision to Diff 44938. emateli added a comment.
- Initialize pointers to nullptr - Code style fix --- Thoughts on proceeding with the proposed changes to batchrenamejob? Also, the filenameutils namespace feels like duplicated work. Any existing solution available to use? It uses QMimeDatabase to look up the extension and if its not found, then it uses the suffix from QFileInfo REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14631?vs=44737&id=44938 BRANCH batchrename2 REVISION DETAIL https://phabricator.kde.org/D14631 AFFECTED FILES autotests/CMakeLists.txt autotests/batchrenametypestest.cpp autotests/batchrenametypestest.h src/widgets/CMakeLists.txt src/widgets/rename/batchrenamedialog.cpp src/widgets/rename/batchrenamedialog.h src/widgets/rename/batchrenamedialogmodel_p.cpp src/widgets/rename/batchrenamedialogmodel_p.h src/widgets/rename/batchrenametypes_p.cpp src/widgets/rename/batchrenametypes_p.h src/widgets/rename/batchrenamevar_p.cpp src/widgets/rename/batchrenamevar_p.h src/widgets/rename/filenameutils_p.cpp src/widgets/rename/filenameutils_p.h tests/CMakeLists.txt tests/batchrenamedialogtest_gui.cpp To: emateli, #frameworks, dfaure, mlaurent Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
