emateli updated this revision to Diff 45438. emateli marked 9 inline comments as done. emateli added a comment.
- create on stack - upd define - remove unused import - use qstringliteral - remove unused export - match file name - remove import prefixes - remove q_unused on used parameter - use fwd class declaration - reserve space for items - Do not use _p for cpp files - simplify expressions - add cpp files w/o _p - optimize imports REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14631?vs=44938&id=45438 BRANCH batchrename2 REVISION DETAIL https://phabricator.kde.org/D14631 AFFECTED FILES autotests/CMakeLists.txt autotests/batchrenametypestest.cpp autotests/batchrenametypestest.h src/widgets/CMakeLists.txt src/widgets/rename/batchrenamedialog.cpp src/widgets/rename/batchrenamedialog.h src/widgets/rename/batchrenamedialogmodel.cpp src/widgets/rename/batchrenamedialogmodel_p.h src/widgets/rename/batchrenametypes.cpp src/widgets/rename/batchrenametypes_p.h src/widgets/rename/batchrenamevar.cpp src/widgets/rename/batchrenamevar_p.h src/widgets/rename/filenameutils.cpp src/widgets/rename/filenameutils_p.h tests/CMakeLists.txt tests/batchrenamedialogtest_gui.cpp To: emateli, #frameworks, dfaure, mlaurent Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
