mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:65
> + rename/batchrenamedialog.cpp
> + rename/batchrenamedialogmodel_p.cpp
> + rename/batchrenametypes_p.cpp
fix indent
> batchrenamedialog.cpp:48
> +{
> + auto *mainLayout = new QVBoxLayout();
> + setWindowTitle(i18nc("@title:window", "Rename Items"));
new QVBoxLayout(this);
and remove setLayout(mainLayout);
> batchrenamedialog.cpp:60
> +
> + m_previewTable = new QTableView();
> + m_previewTable->setModel(model);
add parent ?
> batchrenamedialog.cpp:172
> + // Button Bar
> + auto *buttonBox = new QDialogButtonBox(QDialogButtonBox::Ok |
> QDialogButtonBox::Cancel | QDialogButtonBox::Help);
> + m_btnOk = buttonBox->button(QDialogButtonBox::Ok);
add parent here too
> batchrenamevar_p.h:25
> +
> +#include <QtCore/QStringLiteral>
> +#include <QtCore/QString>
not necessary to add QtCore
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14631
To: emateli, #frameworks, dfaure, mlaurent
Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel,
michaelh, bruns
