emateli updated this revision to Diff 42324. emateli marked 15 inline comments as done. emateli added a comment.
- Code style fixes - use .insert instead of [] - Indent Q_OBJECT - use isEmpty instead of len==0 - use aggregate initialization - protected -> private - added parent check - use functions instead of QString fields - delete itemData - code format - FileNameUtils converted to namespace - remove unnecessary using REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14631?vs=39137&id=42324 BRANCH batchrename2 REVISION DETAIL https://phabricator.kde.org/D14631 AFFECTED FILES autotests/CMakeLists.txt autotests/batchrenametypestest.cpp autotests/batchrenametypestest.h src/widgets/CMakeLists.txt src/widgets/rename/batchrenamedialog.cpp src/widgets/rename/batchrenamedialog.h src/widgets/rename/batchrenamedialogmodel.cpp src/widgets/rename/batchrenamedialogmodel.h src/widgets/rename/batchrenametypes.cpp src/widgets/rename/batchrenametypes.h src/widgets/rename/batchrenamevar.cpp src/widgets/rename/batchrenamevar.h src/widgets/rename/filenameutils.cpp src/widgets/rename/filenameutils.h tests/CMakeLists.txt tests/batchrenamedialogtest_gui.cpp To: emateli, #frameworks, dfaure Cc: asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
