> On Ян. 3, 2017, 12:51 преди обяд, Albert Astals Cid wrote: > > Without knowing anything about baloo this looks totally wrong > > > > QList<KFileMetaData::Extractor*> exList = > > m_extractorCollection.fetchExtractors(mimetype); > > > > why would not you want to iterate over all the iterators that support a > > given mimetype?
It's a waste of time. Extractor should store file content in DB for fast access when file content search is performed, so if more than one extractor performs a file it will result in high cpu usage and huge transaction size in DB, basically file content * num of extractors, at least we loose time and disk size for nothing. - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/#review101748 ----------------------------------------------------------- On Дек. 27, 2016, 7:34 преди обяд, Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129703/ > ----------------------------------------------------------- > > (Updated Дек. 27, 2016, 7:34 преди обяд) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Processing large directories, +5000 files, can be CPU eater. Large file, > itself, can be another issue. > > > Diffs > ----- > > src/file/extractor/app.cpp 97332469 > src/tools/balooctl/indexer.cpp 45e42c1c > > Diff: https://git.reviewboard.kde.org/r/129703/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Fieroni > >
