> On Дек. 26, 2016, 2:24 преди обяд, Aleix Pol Gonzalez wrote: > > src/file/extractor/app.cpp, line 85 > > <https://git.reviewboard.kde.org/r/129703/diff/1/?file=488118#file488118line85> > > > > FWIW, something looks incorrect here, as it seems be using Urls as > > paths. I know it's unrelated but maybe you can check?
QByteArray Transaction::documentUrl(quint64 id) const Url is stored as QByteArray in db, it looks correct. > On Дек. 26, 2016, 2:24 преди обяд, Aleix Pol Gonzalez wrote: > > src/file/extractor/app.cpp, line 81 > > <https://git.reviewboard.kde.org/r/129703/diff/1/?file=488118#file488118line81> > > > > Why is 32 better than 10? It can be better only in corner cases, i.e. other CPU eater process works at same time. Main problem is that KFileMetadata::fetchExtractors returns all known extractors for unsported mimetype https://api.kde.org/frameworks/kfilemetadata/html/extractorcollection_8cpp_source.html#l00143 - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/#review101575 ----------------------------------------------------------- On Дек. 25, 2016, 3:27 след обяд, Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129703/ > ----------------------------------------------------------- > > (Updated Дек. 25, 2016, 3:27 след обяд) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Processing large directories, +5000 files, can be CPU eater. Large file, > itself, can be another issue. > > > Diffs > ----- > > src/file/extractor/app.cpp 97332469 > > Diff: https://git.reviewboard.kde.org/r/129703/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Fieroni > >
