> On Дек. 26, 2016, 2:24 преди обяд, Aleix Pol Gonzalez wrote:
> > src/file/extractor/app.cpp, line 85
> > <https://git.reviewboard.kde.org/r/129703/diff/1/?file=488118#file488118line85>
> >
> >     FWIW, something looks incorrect here, as it seems be using Urls as 
> > paths. I know it's unrelated but maybe you can check?
> 
> Anthony Fieroni wrote:
>     QByteArray Transaction::documentUrl(quint64 id) const
>     Url is stored as QByteArray in db, it looks correct.
> 
> Aleix Pol Gonzalez wrote:
>     It's fine that it's a QByteArray, the problem is whether it has the 
> "file://" prefix.

Does not 
https://github.com/KDE/baloo/blob/master/src/tools/balooctl/main.cpp#L202
balooctl indexing absolute paths only.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129703/#review101575
-----------------------------------------------------------


On Дек. 25, 2016, 3:27 след обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129703/
> -----------------------------------------------------------
> 
> (Updated Дек. 25, 2016, 3:27 след обяд)
> 
> 
> Review request for Baloo and Vishesh Handa.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> Processing large directories, +5000 files, can be CPU eater. Large file, 
> itself, can be another issue.
> 
> 
> Diffs
> -----
> 
>   src/file/extractor/app.cpp 97332469 
> 
> Diff: https://git.reviewboard.kde.org/r/129703/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Reply via email to