> On Ян. 9, 2017, 8:50 след обяд, Albert Astals Cid wrote:
> > src/tools/balooctl/indexer.cpp, line 54
> > <https://git.reviewboard.kde.org/r/129703/diff/3/?file=488856#file488856line54>
> >
> >     Why? Aren't extractors independent? What has one giving no output have 
> > to do with the next giving output or not?

They are independent, *potentially* first extractor should be enough, but it 
may change previous behavior if we stop after him. Note 
https://git.reviewboard.kde.org/r/129720/ after all i try to improve situation, 
but it can cause side effect.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129703/#review101914
-----------------------------------------------------------


On Ян. 9, 2017, 7:48 преди обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129703/
> -----------------------------------------------------------
> 
> (Updated Ян. 9, 2017, 7:48 преди обяд)
> 
> 
> Review request for Baloo, Boudhayan Gupta, Pinak Ahuja, and Vishesh Handa.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> Processing large directories, +5000 files, can be CPU eater. Large file, 
> itself, can be another issue.
> 
> 
> Diffs
> -----
> 
>   src/file/extractor/app.cpp 97332469 
>   src/file/extractor/result.h c800b0dd 
>   src/file/extractor/result.cpp 072aebc6 
>   src/tools/balooctl/indexer.cpp 45e42c1c 
> 
> Diff: https://git.reviewboard.kde.org/r/129703/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Reply via email to