----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129703/#review101591 -----------------------------------------------------------
src/tools/balooctl/indexer.cpp (line 53) <https://git.reviewboard.kde.org/r/129703/#comment68006> This may be a dumb comment, but if there are multiple extractors, each potentially pulling metadata in a different way (say, one pulls demographics of the file, its type, its size, etc) and the other pulls metadata from the file itself, wouldn't we want that to be supported? This loop only appears to be running multiple extractions in the event that there are multiple extractors for the mime-type, each potentially sticking information into different parts of the `result`. Does that make sense? It may be a dumb point, but I'm curious to see where I'm wrong. - Michael Stemle On Dec. 27, 2016, 5:34 a.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129703/ > ----------------------------------------------------------- > > (Updated Dec. 27, 2016, 5:34 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Processing large directories, +5000 files, can be CPU eater. Large file, > itself, can be another issue. > > > Diffs > ----- > > src/file/extractor/app.cpp 97332469 > src/tools/balooctl/indexer.cpp 45e42c1c > > Diff: https://git.reviewboard.kde.org/r/129703/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Fieroni > >
