AndrewJSchofield commented on code in PR #18671:
URL: https://github.com/apache/kafka/pull/18671#discussion_r1932200963
##########
clients/src/main/java/org/apache/kafka/clients/admin/ListShareGroupOffsetsResult.java:
##########
@@ -37,7 +37,7 @@ public class ListShareGroupOffsetsResult {
private final Map<String, KafkaFuture<Map<TopicPartition, Long>>> futures;
- ListShareGroupOffsetsResult(final Map<CoordinatorKey,
KafkaFuture<Map<TopicPartition, Long>>> futures) {
+ public ListShareGroupOffsetsResult(final Map<CoordinatorKey,
KafkaFuture<Map<TopicPartition, Long>>> futures) {
Review Comment:
Yes, I see but this is a problem. One of the parameters is a
`o.a.k.clients.admin.internals.CoordinatorKey`. That type is not part of the
public interfaces. What people tend to do is used code in the
`o.a.k.clients.admin` package to construct Kafka admin objects using the
package-private constructors.
I think you're going to have to see how to work around it because this
constructor cannot be public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
