sjhajharia commented on code in PR #18671:
URL: https://github.com/apache/kafka/pull/18671#discussion_r1932607123
##########
clients/src/main/java/org/apache/kafka/clients/admin/ListShareGroupOffsetsResult.java:
##########
@@ -37,7 +37,7 @@ public class ListShareGroupOffsetsResult {
private final Map<String, KafkaFuture<Map<TopicPartition, Long>>> futures;
- ListShareGroupOffsetsResult(final Map<CoordinatorKey,
KafkaFuture<Map<TopicPartition, Long>>> futures) {
+ public ListShareGroupOffsetsResult(final Map<CoordinatorKey,
KafkaFuture<Map<TopicPartition, Long>>> futures) {
Review Comment:
Thanks @smjn. I have made changes in GroupCoordinatorService accordingly. I
have also refactored the GroupCoordinatorServiceTest accordingly. Pls review if
that looks good.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java:
##########
@@ -256,6 +258,18 @@
CompletableFuture<OffsetFetchResponseData.OffsetFetchResponseGroup> fetchAllOffs
boolean requireStable
);
+ /**
+ * Fetch the Share Group Offsets for a given group.
+ *
+ * @param context The request context
+ * @param request The DescribeShareGroupOffsets request.
+ * @return A future yielding the results.
+ */
+ CompletableFuture<ReadShareGroupStateSummaryResponseData>
describeShareGroupOffsets(
Review Comment:
Thanks @smjn. I have made changes in GroupCoordinatorService accordingly. I
have also refactored the GroupCoordinatorServiceTest accordingly. Pls review if
that looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
