sjhajharia commented on code in PR #18671: URL: https://github.com/apache/kafka/pull/18671#discussion_r1931720091
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ########## @@ -935,6 +958,53 @@ public CompletableFuture<OffsetFetchResponseData.OffsetFetchResponseGroup> fetch } } + /** + * See {@link GroupCoordinator#describeShareGroupOffsets(RequestContext, ReadShareGroupStateSummaryRequestData)}. + */ + @Override + public CompletableFuture<ReadShareGroupStateSummaryResponseData> describeShareGroupOffsets( + RequestContext context, + ReadShareGroupStateSummaryRequestData requestData + ) { + if (!isActive.get()) { + return CompletableFuture.completedFuture( + new ReadShareGroupStateSummaryResponseData() + .setResults(ReadShareGroupStateSummaryRequest.getErrorReadShareGroupStateSummary( + requestData.topics(), + Errors.COORDINATOR_NOT_AVAILABLE + )) + ); + } + CompletableFuture<ReadShareGroupStateSummaryResponseData> future = new CompletableFuture<>(); + persister.readSummary(ReadShareGroupStateSummaryParameters.from(requestData)) + .whenComplete((result, error) -> { + if (error != null) { + log.error("Failed to read summary of the share partition"); + future.completeExceptionally(error); + return; Review Comment: Added some more tests to GroupCoordinatorServiceTest ########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ########## @@ -935,6 +958,53 @@ public CompletableFuture<OffsetFetchResponseData.OffsetFetchResponseGroup> fetch } } + /** + * See {@link GroupCoordinator#describeShareGroupOffsets(RequestContext, ReadShareGroupStateSummaryRequestData)}. + */ + @Override + public CompletableFuture<ReadShareGroupStateSummaryResponseData> describeShareGroupOffsets( + RequestContext context, + ReadShareGroupStateSummaryRequestData requestData + ) { + if (!isActive.get()) { + return CompletableFuture.completedFuture( + new ReadShareGroupStateSummaryResponseData() + .setResults(ReadShareGroupStateSummaryRequest.getErrorReadShareGroupStateSummary( + requestData.topics(), + Errors.COORDINATOR_NOT_AVAILABLE + )) + ); + } + CompletableFuture<ReadShareGroupStateSummaryResponseData> future = new CompletableFuture<>(); + persister.readSummary(ReadShareGroupStateSummaryParameters.from(requestData)) + .whenComplete((result, error) -> { + if (error != null) { + log.error("Failed to read summary of the share partition"); + future.completeExceptionally(error); + return; + } + if (result == null || result.topicsData() == null || result.topicsData().isEmpty()) { + log.error("Result is null for the read state summary"); + future.completeExceptionally(new IllegalStateException("Result is null for the read state summary")); + return; + } Review Comment: Added some more tests to GroupCoordinatorServiceTest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org