smjn commented on code in PR #18671:
URL: https://github.com/apache/kafka/pull/18671#discussion_r1933400811
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -935,6 +955,78 @@ public
CompletableFuture<OffsetFetchResponseData.OffsetFetchResponseGroup> fetch
}
}
+ /**
+ * See {@link GroupCoordinator#describeShareGroupOffsets(RequestContext,
DescribeShareGroupOffsetsRequestData)}.
+ */
+ @Override
+ public CompletableFuture<DescribeShareGroupOffsetsResponseData>
describeShareGroupOffsets(
+ RequestContext context,
+ DescribeShareGroupOffsetsRequestData requestData
+ ) {
+ if (!isActive.get()) {
Review Comment:
I think you should move the impl for this method to OffsetsManager in line
with existing methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
