smjn commented on code in PR #18671:
URL: https://github.com/apache/kafka/pull/18671#discussion_r1933394024
##########
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##########
@@ -8970,4 +8974,85 @@ public void testRemoveRaftVoterRequest(boolean fail,
boolean sendClusterId) thro
assertEquals(Uuid.fromString("YAfa4HClT3SIIW2klIUspg"),
requestData.get().voterDirectoryId());
}
}
+
+ @Test
+ public void testListShareGroupOffsetsOptionsWithBatchedApi() {
+ final Cluster cluster = mockCluster(3, 0);
+ final Time time = new MockTime();
+
+ try (AdminClientUnitTestEnv env = new AdminClientUnitTestEnv(time,
cluster,
+ AdminClientConfig.RETRIES_CONFIG, "0")) {
+ env.kafkaClient().setNodeApiVersions(NodeApiVersions.create());
+
+
env.kafkaClient().prepareResponse(prepareFindCoordinatorResponse(Errors.NONE,
env.cluster().controller()));
+
+ final List<TopicPartition> partitions =
Collections.singletonList(new TopicPartition("A", 0));
+ final ListShareGroupOffsetsOptions options = new
ListShareGroupOffsetsOptions();
+
+ final ListShareGroupOffsetsSpec groupSpec = new
ListShareGroupOffsetsSpec()
+ .topicPartitions(partitions);
+ Map<String, ListShareGroupOffsetsSpec> groupSpecs = new
HashMap<>();
+ groupSpecs.put(GROUP_ID, groupSpec);
+
+ env.adminClient().listShareGroupOffsets(groupSpecs, options);
+
+ final MockClient mockClient = env.kafkaClient();
+ waitForRequest(mockClient, ApiKeys.DESCRIBE_SHARE_GROUP_OFFSETS);
+
+ ClientRequest clientRequest = mockClient.requests().peek();
+ assertNotNull(clientRequest);
+ DescribeShareGroupOffsetsRequestData data =
((DescribeShareGroupOffsetsRequest.Builder)
clientRequest.requestBuilder()).build().data();
+ assertEquals(GROUP_ID, data.groupId());
+ assertEquals(Collections.singletonList("A"),
+
data.topics().stream().map(DescribeShareGroupOffsetsRequestData.DescribeShareGroupOffsetsRequestTopic::topicName).collect(Collectors.toList()));
+ } catch (Exception e) {
+ throw new RuntimeException(e);
Review Comment:
fail the test instead
`fail(e)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
