cmccabe commented on code in PR #17952:
URL: https://github.com/apache/kafka/pull/17952#discussion_r1887363310
##########
metadata/src/main/java/org/apache/kafka/metadata/KafkaConfigSchema.java:
##########
@@ -224,6 +224,24 @@ public ConfigEntry resolveEffectiveTopicConfig(
ConfigSource.DEFAULT_CONFIG, Function.identity());
}
+ public String getStaticOrDefaultConfig(
+ String configName,
+ Map<String, ?> staticNodeConfig
+ ) {
+ ConfigDef configDef =
configDefs.getOrDefault(ConfigResource.Type.BROKER, EMPTY_CONFIG_DEF);
Review Comment:
Why are we using EMPTY_CONFIG_DEF?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
