cmccabe commented on code in PR #17952:
URL: https://github.com/apache/kafka/pull/17952#discussion_r1887262355
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -283,6 +315,10 @@ private ApiError validateAlterConfig(ConfigResource
configResource,
for (ApiMessageAndVersion newRecord : recordsExplicitlyAltered) {
ConfigRecord configRecord = (ConfigRecord) newRecord.message();
if (configRecord.value() == null) {
+ if (featureControl.isElrFeatureEnabled() &&
configResource.equals(DEFAULT_NODE) &&
+ configRecord.name() == MIN_IN_SYNC_REPLICAS_CONFIG) {
Review Comment:
Why are you using `==` on a Java string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
