cmccabe commented on code in PR #17952:
URL: https://github.com/apache/kafka/pull/17952#discussion_r1887261139
##########
metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java:
##########
@@ -148,11 +155,16 @@ static ControllerResult<Void> generate(
boolean isEmpty,
long transactionStartOffset,
BootstrapMetadata bootstrapMetadata,
- MetadataVersion curMetadataVersion
- ) {
+ MetadataVersion curMetadataVersion,
+ ConfigurationControlManager configurationControl) {
if (isEmpty) {
return recordsForEmptyLog(activationMessageConsumer,
transactionStartOffset,
- bootstrapMetadata, bootstrapMetadata.metadataVersion());
+ bootstrapMetadata, bootstrapMetadata.metadataVersion(),
+ FeatureControlManager.isElrFeatureEnabled(
Review Comment:
This should just be a method on `BootstrapMetadata`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
