cmccabe commented on code in PR #17952:
URL: https://github.com/apache/kafka/pull/17952#discussion_r1887263517
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -303,6 +339,14 @@ private ApiError validateAlterConfig(ConfigResource
configResource,
if (alterConfigPolicy.isPresent()) {
alterConfigPolicy.get().validate(new
RequestMetadata(configResource, alteredConfigsForAlterConfigPolicyCheck));
}
+ if (featureControl.isElrFeatureEnabled()) {
+ if (configResource.type() == Type.BROKER &&
!configResource.name().isEmpty()) {
+ for (Entry record : allConfigs.entrySet()) {
+ if (record.getKey() == MIN_IN_SYNC_REPLICAS_CONFIG &&
record.getValue() != null)
Review Comment:
Do not use `==` on Java strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
