cmccabe commented on code in PR #17952:
URL: https://github.com/apache/kafka/pull/17952#discussion_r1887266784
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -497,10 +541,63 @@ public Map<ConfigResource, ResultOrError<Map<String,
String>>> describeConfigs(
return results;
}
+ // The function is used when enabling ELR. It will create a new cluster
level min ISR config if there is not any.
+ // Also, it will remove all the broker level min ISR config records.
+ void maybeResetMinIsrConfig(List<ApiMessageAndVersion> outputRecords) {
+ if (!clusterConfig().containsKey(MIN_IN_SYNC_REPLICAS_CONFIG)) {
+ String minIsrDefaultConfigValue =
configSchema.getStaticOrDefaultConfig(
Review Comment:
We should log a message if we are doing this. Also, it seems easier just to
create the configuration record directly than call a function here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
