mjsax commented on code in PR #16906:
URL: https://github.com/apache/kafka/pull/16906#discussion_r1727731596
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStore.java:
##########
@@ -241,11 +241,10 @@ public String name() {
return name;
}
- @Deprecated
@Override
- public void init(final ProcessorContext context,
- final StateStore root) {
- this.context = context;
+ public void init(final StateStoreContext stateStoreContext, final
StateStore root) {
+ this.stateStoreContext = stateStoreContext;
+ this.context = StoreToProcessorContextAdapter.adapt(stateStoreContext);
Review Comment:
This feels rather hacky -- using `adapt` was a workaround as long as we have
both `init()` methods. I think, we need to do more cleanup/refactoring and get
rid or `this.context` completely.
In other stores, we use `InternalProcessorContext` -- I think doing the same
here would be the right way forward (and get rid of both `stateStoreContext`
and `context` in favor of `internalProcessorContext`)?
Applies elsewhere, too.
(Ideally, we should be able to delete class `StoreToProcessorContextAdapter`
entirely)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
