mjsax commented on code in PR #16906:
URL: https://github.com/apache/kafka/pull/16906#discussion_r1727754451
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/TimeOrderedCachingWindowStore.java:
##########
@@ -108,37 +106,21 @@ private RocksDBTimeOrderedWindowStore
getWrappedStore(final StateStore wrapped)
return null;
}
- @Deprecated
- @Override
- public void init(final ProcessorContext context, final StateStore root) {
- initInternal(asInternalProcessorContext(context));
- super.init(context, root);
- }
-
@Override
public void init(final StateStoreContext context, final StateStore root) {
- initInternal(asInternalProcessorContext(context));
- super.init(context, root);
- }
-
- private void initInternal(final InternalProcessorContext<?, ?> context) {
- final String prefix = StreamsConfig.InternalConfig.getString(
- context.appConfigs(),
- StreamsConfig.InternalConfig.TOPIC_PREFIX_ALTERNATIVE,
- context.applicationId()
- );
- this.context = context;
- final String topic = ProcessorStateManager.storeChangelogTopic(prefix,
name(), context.taskId().topologyName());
+ this.context = asInternalProcessorContext(context);
+ final String topic = ProcessorContextUtils.changelogFor(context,
name(), Boolean.TRUE);
Review Comment:
Can we exclude this change from this PR, as this PR should only remove
`init()` to address KAFKA-12829, and pull this change into a follow up PR for
KAFKA-13588.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
