chia7712 commented on code in PR #16906:
URL: https://github.com/apache/kafka/pull/16906#discussion_r1726106625
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStore.java:
##########
@@ -241,10 +241,8 @@ public String name() {
return name;
}
- @Deprecated
- @Override
- public void init(final ProcessorContext context,
- final StateStore root) {
+ private void initInternal(final ProcessorContext context,
Review Comment:
Could you please merge `initInternal` into `init`? we don't need to have a
private method used to generate a small public method :)
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java:
##########
@@ -294,10 +294,8 @@ public String name() {
return name;
}
- @Deprecated
- @Override
- public void init(final ProcessorContext context,
- final StateStore root) {
+ private void initInternal(final ProcessorContext context,
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
