mjsax commented on code in PR #16906:
URL: https://github.com/apache/kafka/pull/16906#discussion_r1731836659


##########
streams/test-utils/src/main/java/org/apache/kafka/streams/processor/api/MockProcessorContext.java:
##########
@@ -533,4 +544,237 @@ public Map<String, Object> appConfigsWithPrefix(final 
String prefix) {
             }
         };
     }
+
+
+    public InternalProcessorContext getInternalProcessorContext() {

Review Comment:
   `MockProcessorContext` is public API and we cannot just add this. -- I 
assume this was necessary to fix some tests? For this case, we should do it 
differently.



##########
checkstyle/suppressions.xml:
##########
@@ -193,7 +193,7 @@
               
files="(KafkaStreams|KStreamImpl|KTableImpl|InternalTopologyBuilder|StreamsPartitionAssignor|StreamThread|IQv2StoreIntegrationTest|KStreamImplTest|RocksDBStore|StreamTask).java"/>
 
     <suppress checks="MethodLength"
-              files="KTableImpl.java"/>
+              files="(KTableImpl|MockProcessorContext).java"/>

Review Comment:
   I hope we don't need this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to