chia7712 commented on code in PR #16906:
URL: https://github.com/apache/kafka/pull/16906#discussion_r1722595049
##########
streams/src/main/java/org/apache/kafka/streams/processor/StateStore.java:
##########
@@ -95,9 +69,7 @@ public interface StateStore {
* @throws IllegalStateException If store gets registered after
initialized is already finished
* @throws StreamsException if the store's change log does not contain the
partition
*/
- default void init(final StateStoreContext context, final StateStore root) {
- init(StoreToProcessorContextAdapter.adapt(context), root);
- }
+ default void init(final StateStoreContext context, final StateStore root)
{}
Review Comment:
This is used to replace the deprecated `init`, so I guess it should NOT have
default implementation after removing the deprecated version?
@guozhangwang WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
