dsmiley commented on code in PR #3919: URL: https://github.com/apache/solr/pull/3919#discussion_r2612160372
########## solr/modules/language-models/src/test-files/solr/collection1/conf/schema.xml: ########## @@ -39,6 +40,8 @@ <field name="_version_" type="plong" indexed="true" stored="true" multiValued="false" /> <field name="_text_" type="text_general" indexed="true" stored="false" multiValued="true"/> <copyField source="*" dest="_text_"/> + <field name="vectorised" type="boolean" indexed="true" stored="false" docValues="true" default="false"/> Review Comment: I'd prefer to see a dynamicField pattern, thus of general utility (and placed near other dynamic field definitions), instead of specifically `vectorised`. ########## solr/solr-ref-guide/modules/query-guide/pages/text-to-vector.adoc: ########## @@ -382,7 +382,7 @@ You still define two chains, but this time the 'vectorisation' one only includes [NOTE] ==== -Partial updates are processed by the `DistributedUpdateProcessorFactory`. For this reason, it must be placed at the beginning of the UpdateRequestProcessorChain, before the `TextToVectorUpdateProcessorFactory`. +Since Partial updates are processed by the `DistributedUpdateProcessorFactory`, this processor must be placed at the beginning of the UpdateRequestProcessorChain, before the `TextToVectorUpdateProcessorFactory`. Review Comment: It's still confusing IMO -- "this" is ambiguous. I suggest the following: > Since partial updates are resolved by `DistributedUpdateProcessorFactory`, be sure to place `TextToVectorUpdateProcessorFactory` afterwards so that it sees normal/complete documents. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
