ilariapet commented on code in PR #3919:
URL: https://github.com/apache/solr/pull/3919#discussion_r2610485314
##########
solr/solr-ref-guide/modules/query-guide/pages/text-to-vector.adoc:
##########
@@ -356,29 +356,35 @@ You still define two chains, but this time the
'vectorisation' one only includes
[source,xml]
----
<updateRequestProcessorChain name="no-vectorisation">
-<processor class="solr.processor1">
+ <processor class="solr.processor1">
...
</processor>
-...
-<processor class="solr.processorN">
+ ...
+ <processor class="solr.processorN">
...
</processor>
<processor class="solr.RunUpdateProcessorFactory"/>
- </updateRequestProcessorChain>
+</updateRequestProcessorChain>
----
[source,xml]
----
<updateRequestProcessorChain name="vectorisation">
-<processor
class="solr.llm.textvectorisation.update.processor.TextToVectorUpdateProcessorFactory">
+ <processor class="solr.DistributedUpdateProcessorFactory"/>
+ <processor
class="solr.llm.textvectorisation.update.processor.TextToVectorUpdateProcessorFactory">
<str name="inputField">_text_</str>
<str name="outputField">vector</str>
<str name="model">dummy-1</str>
</processor>
<processor class="solr.RunUpdateProcessorFactory"/>
- </updateRequestProcessorChain>
+</updateRequestProcessorChain>
----
+[NOTE]
+====
+Partial updates are processed by the `DistributedUpdateProcessorFactory`. For
this reason, it must be placed at the beginning of the
UpdateRequestProcessorChain, before the `TextToVectorUpdateProcessorFactory`.
Review Comment:
I’ll rephrase it more clearly.
##########
solr/solr-ref-guide/modules/query-guide/pages/text-to-vector.adoc:
##########
@@ -356,29 +356,35 @@ You still define two chains, but this time the
'vectorisation' one only includes
[source,xml]
----
<updateRequestProcessorChain name="no-vectorisation">
-<processor class="solr.processor1">
+ <processor class="solr.processor1">
...
</processor>
-...
-<processor class="solr.processorN">
+ ...
+ <processor class="solr.processorN">
...
</processor>
<processor class="solr.RunUpdateProcessorFactory"/>
- </updateRequestProcessorChain>
+</updateRequestProcessorChain>
----
[source,xml]
----
<updateRequestProcessorChain name="vectorisation">
-<processor
class="solr.llm.textvectorisation.update.processor.TextToVectorUpdateProcessorFactory">
+ <processor class="solr.DistributedUpdateProcessorFactory"/>
+ <processor
class="solr.llm.textvectorisation.update.processor.TextToVectorUpdateProcessorFactory">
<str name="inputField">_text_</str>
<str name="outputField">vector</str>
<str name="model">dummy-1</str>
</processor>
<processor class="solr.RunUpdateProcessorFactory"/>
- </updateRequestProcessorChain>
+</updateRequestProcessorChain>
----
+[NOTE]
+====
+Partial updates are processed by the `DistributedUpdateProcessorFactory`. For
this reason, it must be placed at the beginning of the
UpdateRequestProcessorChain, before the `TextToVectorUpdateProcessorFactory`.
Review Comment:
I’ll rephrase it more clearly. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
