dsmiley commented on code in PR #3919: URL: https://github.com/apache/solr/pull/3919#discussion_r2610760392
########## solr/modules/language-models/src/test-files/solr/collection1/conf/schema.xml: ########## @@ -20,6 +20,7 @@ <schema name="schema-densevector" version="1.7"> <fieldType name="string" class="solr.StrField" multiValued="true"/> + <fieldType name="boolean" class="solr.BoolField" sortMissingLast="true"/> Review Comment: the field type is a fine addition as it's a basic type. But I'd rather see a dynamicField for booleans rather than add a named field -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
